Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty payment logic fixes #4395

Open
wants to merge 3 commits into
base: mainnet
Choose a base branch
from

Conversation

Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Oct 20, 2022

Addresses #4192

┆Issue is synchronized with this Asana task by Unito

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Nov 23, 2022 at 6:45AM (UTC)

@bedeho
Copy link
Member

bedeho commented Oct 26, 2022

We are merging this into carthage, right?, but just filtering out?

@Lezek123
Copy link
Contributor Author

We are merging this into carthage, right?, but just filtering out?

Sure, we can merge it to Carthage, create_bounty call is filtered out in Carthage

@bedeho
Copy link
Member

bedeho commented Nov 17, 2022

What is status of this.

@Lezek123
Copy link
Contributor Author

What is status of this.

Just needs to be reviewed I think, who should I assign?

@Lezek123 Lezek123 changed the base branch from carthage to mainnet November 17, 2022 16:47
@bedeho
Copy link
Member

bedeho commented Nov 17, 2022

@ignazio-bovo

ignazio-bovo
ignazio-bovo previously approved these changes Nov 22, 2022
Copy link
Contributor

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I just left a small comment

runtime-modules/bounty/src/actors.rs Outdated Show resolved Hide resolved
Co-authored-by: Ignazio Bovo <bovoignazio.dev@gmail.com>
Copy link
Contributor

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants