Orion signup flow rework #321
Open
+992
−822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WRadoslaw
reviewed
Mar 20, 2024
| id: ID! | ||
|
|
||
| "Membership associated with the blockchain account (controllerAccount)" | ||
| memberships: [Membership!] @derivedFrom(field: "controllerAccount") |
There was a problem hiding this comment.
Should we support multiple memberships within Atlas? Seems, like an overkill. Besides that it is possible from runtime perspective, it will only complicate the membership dropdown (we already had some feedback that it is complicated @dmtrjsg)
| { joystreamAccountId: payload.joystreamAccountId } | ||
| ) | ||
|
|
||
| console.log('after update') |
| }) | ||
|
|
||
| // Mark the token as used | ||
| token.expiry = new Date() |
There was a problem hiding this comment.
Can't we just drop the token if used?
zeeshanakram3
force-pushed
the
orion_signup-flow-rework
branch
from
75160c2
to
2fba0a5
Compare
zeeshanakram3
force-pushed
the
orion_signup-flow-rework
branch
from
6f8a7d0
to
d580268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #320