Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[USERSNAP] Restore Votes does not upate My Votes #2991

Open
1 task
dmtrjsg opened this issue May 7, 2022 · 4 comments · May be fixed by #3868
Open
1 task

[USERSNAP] Restore Votes does not upate My Votes #2991

dmtrjsg opened this issue May 7, 2022 · 4 comments · May be fixed by #3868
Assignees
@chrlschwb
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod scope:council SP:2
Projects
Pioneer Community Product Development

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented May 7, 2022 •
edited

  • Refetch the page after restoring votes from JSON file

Solution on refetching query was added recently @thesan can you pls point to the right place?

Taken at: https://dao.joystream.org/#/election
Fields:

  • Houston, we have a problem.: Restore Votes does not upate My Votes
  • Comment: The votes are restored from file but user has to reload the page manually.
  • Feedback: l1dev

SCREENSHOT
Download original image

Browser: Chrome 100 (Linux)
Screen size: 1920x1080
Browser size: 1190x1216
Open #242 in Usersnap

Powered by Usersnap.
@dmtrjsg dmtrjsg added the bug Something isn't working label May 7, 2022
@dmtrjsg dmtrjsg self-assigned this May 7, 2022
@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Jun 6, 2022

Probably must be addressed in #2311. To be triaged.

@dmtrjsg dmtrjsg added community-dev issue suitable for community-dev pipeline SP:2 and removed to-triage labels Jun 8, 2022
@dmtrjsg dmtrjsg added this to Community Dev Backlog in Pioneer Community Product Development Jun 9, 2022
@dmtrjsg dmtrjsg moved this from Community Dev Backlog to Bounties Backlog in Pioneer Community Product Development Jul 19, 2022
@traumschule traumschule mentioned this issue Oct 21, 2022
Open
@ivanturlakov
Copy link

Tested on https://dao-git-carthage-joystream.vercel.app/#/election
wss://54.227.116.57.nip.io/ws-rpc

@traumschule @dmtrjsg Looks like not fixed yet

⚠️ The votes are restored from file but user has to reload the page manually. Tested on Voting and Revealing stages.

To test this case, I voted for a few candidates then backup votes, and then deleted votes from Local Storage.

@traumschule
Copy link
Contributor

There's a fix in #3868 by @mkbeefcake.

@traumschule traumschule mentioned this issue Nov 24, 2022
Open
@dmtrjsg dmtrjsg moved this from Bounties Backlog to Ready to Test in Pioneer Community Product Development Nov 24, 2022
@mkbeefcake mkbeefcake linked a pull request Dec 5, 2022 that will close this issue
Open
@ivanturlakov
Copy link

ivanturlakov commented Jan 13, 2023 •
edited

Tested on https://dao-keoneo7vf-joystream.vercel.app/#/election
wss://34.230.5.182.nip.io/ws-rpc

Works as expected on this env. Page updated after restoring votes

Снимок экрана 2023-01-13 в 16 00 15

Снимок экрана 2023-01-13 в 16 00 33

Снимок экрана 2023-01-13 в 16 00 47

Снимок экрана 2023-01-13 в 16 01 43

@dmtrjsg dmtrjsg mentioned this issue Jan 24, 2023
Open
@chrlschwb chrlschwb moved this from Ready to Test to Tested - Ready for Prod in Pioneer Community Product Development Jan 25, 2023
@chrlschwb chrlschwb self-assigned this Mar 22, 2023
@chrlschwb chrlschwb moved this from Tested - Ready for Prod to In Review in Pioneer Community Product Development Mar 22, 2023
@chrlschwb chrlschwb mentioned this issue Mar 23, 2023
Closed
@chrlschwb chrlschwb moved this from In Review to Tested - Ready for Prod in Pioneer Community Product Development Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrlschwb chrlschwb

Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod scope:council SP:2
Projects
Pioneer Community Product Development
Tested - Ready for Prod
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed restore_votes not update MyVotes #2991, #2986 mkbeefcake/pioneer
5 participants
@traumschule @ivanturlakov @polikosi @dmtrjsg @chrlschwb