Fixed restore_votes not update MyVotes #2991, #2986 #3868
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
added
community-dev
There was a problem hiding this comment.
Hey! Nice hook logic!
Although I have a question. I don't see any other usage of this hook beside changes in local storage. Could we maybe instead of creating a new hook to dispatch new events, improve useLocalStorage logic to capture changes to itself from other places?
Here is a similar solution to yours, but only on local storage. Link
mkbeefcake
changed the title
I tried to migrate customEvent inside useLocalStorage() hook. it applies the storage updated event to all states which uses same storage key. Please check and give me your feedback |
mkbeefcake
force-pushed
the
fix/myvotes_isnt_updated
branch
from
6b6768c
to
d301b49
Compare
packages/ui/src/council/modals/VoteForCouncil/VoteForCouncilSuccessModal.tsx
Outdated
Show resolved
Hide resolved
| return () => { | ||
| document.removeEventListener(`storage_event_${key}`, handleEventOnce) | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
I'm not sure if the key is ever changed somewhere in the code base, but to at least be consistent with other hooks dependencies called here:
| }, []) | |
| }, [key]) |
| document.removeEventListener(`storage_event_${key}`, handleEventOnce) | ||
| } | ||
| }, []) | ||
|
|
||
| const dispatch = useCallback( | ||
| (setStateAction: T | ((prevState?: T) => T)) => { | ||
| const value = isFunction(setStateAction) ? setStateAction(getItem(key)) : setStateAction | ||
| setState(value) |
There was a problem hiding this comment.
Just to prevent redundant re-renders:
| setState(value) |
|
@chrlschwb why did we decide to close it? Looks like solution was nice and we were close to resolution.. if its due to no access to the branch @thesan could take this over at some point. Please let us know! |
Added customEvent mechanism inside the pioneer and refresh the Election page after Restore Votes clicked.
Fixed #2991, #2986