Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed subcategory layout #3984

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

mkbeefcake
Copy link
Contributor

@mkbeefcake mkbeefcake commented Dec 15, 2022

Fixed the issue
#3913
Screenshot_3

@vercel
Copy link

vercel bot commented Dec 15, 2022

@mkbeefcake is attempting to deploy a commit to the joystream Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 2:33AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 2:33AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 2:33AM (UTC)

Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are differences for category slider and thread row spacing but i'd let it pass.

design
design

after
subcat

items={category.subcategories.map((category) => (
<CategoryCard key={category.id} category={category} />
))}
count={category.subcategories.length}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design shows 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this problem and updated it. please check it again.

@traumschule traumschule added community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Dec 15, 2022
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is according to design but depending on category titles and descriptions it looks pretty empty. maybe 3 or 4 will fit as well. leaving this up to further review. thanks @mkbeefcake!

@mkbeefcake
Copy link
Contributor Author

My pleasure

Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it wasn't very clear in the design (because it shows only 2 categories) but what we meant was to display the categories in a grid, just like how they look on the forum home page:
image
Not in a in a slider.

As a result a some components will become unused: <ForumCategoryList/> <CategoryListItem />, and maybe some others... Please remove them in this PR (as well as there stories if need).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline
Development

Successfully merging this pull request may close these issues.

None yet

4 participants