Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WG opening listing sorted in chronological order (#2513) #4191

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

WG opening listing sorted in chronological order (#2513) #4191

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ffdc640
test
chrlschwb Feb 20, 2023
d1e0813
Update packages/ui/src/working-groups/hooks/useOpeningsPagination.ts
chrlschwb Mar 2, 2023
c564b99
start dev
chrlschwb Mar 30, 2023
19394fd
Merge branch 'dev' of https://github.com/Joystream/pioneer into dev
chrlschwb Apr 10, 2023
e294b08
Merge branch 'dev' of https://github.com/Joystream/pioneer into dev
chrlschwb Apr 13, 2023
3848398
Merge branch 'Joystream:dev' into dev
chrlschwb Jul 31, 2023
d9240cb
Merge branch 'Joystream:dev' into dev
chrlschwb Aug 24, 2023
2f1a367
Merge branch 'Joystream:dev' into dev
chrlschwb Sep 6, 2023
60f8d5f
Merge branch 'Joystream:dev' into dev
chrlschwb Sep 22, 2023
61e07c4
Merge branch 'Joystream:dev' into dev
chrlschwb Sep 25, 2023
3a08da2
Merge branch 'Joystream:dev' into dev
chrlschwb Oct 19, 2023
38cdfad
finish review fixed
chrlschwb Oct 19, 2023
28f31df
Merge branch 'dev' of https://github.com/chrlschwb/pioneer into fix/2…
chrlschwb Oct 20, 2023
7aae86f
update
chrlschwb Oct 20, 2023
5a6ff7f
update finish
chrlschwb Oct 27, 2023
98cc719
update
chrlschwb Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/working-groups/hooks/useOpeningsPagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const useOpeningsPagination = ({ groupId, type, page = 1 }: UseOpeningsPa
limit: OPENINGS_PER_PAGE,
offset: (page - 1) * OPENINGS_PER_PAGE,
where,
order: [WorkingGroupOpeningOrderByInput.CreatedAtDesc, WorkingGroupOpeningOrderByInput.RuntimeIdDesc],
order: [WorkingGroupOpeningOrderByInput.CreatedAtDesc],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this #2513 (comment), the issue is that the openings are ordered by ascending creation date. So this line (order: [WorkingGroupOpeningOrderByInput.CreatedAtDesc, WorkingGroupOpeningOrderByInput.RuntimeIdDesc] looks fine to me, but the problem is still not solved on the preview branch /working-groups/openings:
image

So I'm guessing that maybe this useOpeningsPagination is used to query the openings on a different page. E.g on the WG past openings page the order is correct even in production.

In conclusion I think this change should be reversed and either the hook used to query /working-groups/openings should be fixed or an even better solution would be to reuse the same hook to query openings everywhere.

Also please get reviews from BWG workers before setting jsg-code-review.

}

const { data, loading, error } = useGetWorkingGroupOpeningsQuery({ variables })
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/working-groups/queries/__generated__/workingGroups.generated.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.