Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused proposal types (#4390) #4394

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove unused proposal types (#4390) #4394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b163d
Remove unused proposal types (#4390)
traumschule May 24, 2023
2a33c0d
Drop unused proposal types
traumschule Jun 1, 2023
72c0a30
restore veto; type fixes
Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/ui/src/proposals/hooks/useProposalConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const extendsProposalPallet = (

const proposalTypeToConstantKey = new Map<ProposalType, keyof Api['consts']['proposalsCodex']>([
['updateChannelPayouts', 'updateChannelPayoutsProposalParameters'],
['amendConstitution', 'amendConstitutionProposalParameters'],
['cancelWorkingGroupLeadOpening', 'cancelWorkingGroupLeadOpeningProposalParameters'],
['createWorkingGroupLeadOpening', 'createWorkingGroupLeadOpeningProposalParameters'],
['decreaseWorkingGroupLeadStake', 'decreaseWorkingGroupLeadStakeProposalParameters'],
Expand Down
5 changes: 0 additions & 5 deletions packages/ui/src/proposals/model/proposalDescriptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export const proposalDescriptions: ProposalDescriptions = {
setWorkingGroupLeadReward: 'Same effect as updating the reward of the worker.',
terminateWorkingGroupLead:
'Same as when terminating a worker in group with given inputs, and removing lead designation.',
amendConstitution: 'Proposal to amend constitution. Does not effect platform parameters.',
cancelWorkingGroupLeadOpening: 'Same as when cancelling an opening for workers in the given group with given inputs.',
setMembershipPrice: 'Sets new membership price.',
setCouncilBudgetIncrement:
Expand All @@ -36,9 +35,5 @@ export const proposalDescriptions: ProposalDescriptions = {
updateChannelPayouts:
'Proposal to submit the Channel Incentives Payout payload, update the min/max claimable amounts and block/allow claiming of awarded JOYs by channels.',
runtimeUpgrade: 'Proposal to upgrade version to the new runtime.',
createBlogPost: 'Council blog',
editBlogPost: 'Unlocked blog post can be edited.',
lockBlogPost: 'When a post is locked it can no longer be modified.',
unlockBlogPost: 'Unlocked post can be modified.',
veto: 'Veto for a particular, previously issued proposal. Vetoed proposal is automatically discarded.',
}
1 change: 0 additions & 1 deletion packages/ui/src/proposals/model/proposalDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export const proposalDetails: ProposalType[] = [
'slashWorkingGroupLead',
'setWorkingGroupLeadReward',
'terminateWorkingGroupLead',
'amendConstitution',
'cancelWorkingGroupLeadOpening',
'setMembershipPrice',
'setCouncilBudgetIncrement',
Expand Down
7 changes: 1 addition & 6 deletions packages/ui/src/proposals/types/proposals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export type ProposalType =
| 'slashWorkingGroupLead'
| 'setWorkingGroupLeadReward'
| 'terminateWorkingGroupLead'
| 'amendConstitution'
| 'cancelWorkingGroupLeadOpening'
| 'setMembershipPrice'
| 'setCouncilBudgetIncrement'
Expand All @@ -55,15 +54,11 @@ export type ProposalType =
| 'setInitialInvitationCount'
| 'setMembershipLeadInvitationQuota'
| 'setReferralCut'
| 'createBlogPost'
| 'editBlogPost'
| 'lockBlogPost'
| 'unlockBlogPost'
| 'veto'
| 'updateChannelPayouts'
)

export type DisabledProposal = 'createBlogPost' | 'editBlogPost' | 'lockBlogPost' | 'unlockBlogPost'
export type DisabledProposal = 'veto'

export interface Proposal {
id: string
Expand Down