Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Validator dashboard QA issues #4753

Merged
merged 17 commits into from
Jan 31, 2024
Merged

Address Validator dashboard QA issues #4753

merged 17 commits into from
Jan 31, 2024

Conversation

eshark9312
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Jan 31, 2024 9:42am
pioneer-2 ✅ Ready (Inspect) Visit Preview Jan 31, 2024 9:42am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jan 31, 2024 9:42am

thesan
thesan requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit related to the ExternalResourceLink constant.

But also please add 2 decimals to the aprs

packages/ui/src/common/components/forms/FilterBox/FilterSearchBox.tsx Outdated Show resolved Hide resolved
@kdembler
Copy link
Member

There's this intermediate loading state, where we show some weird stats like:

Validator 43/-43
Nominator 0/329

Can we postpone showing this data until we have the full stats?

CleanShot.2024-01-30.at.16.08.22.mp4

@eshark9312 @thesan
Update packages/ui/src/memberships/constants/externalResourceLink.ts
c366f5d 
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
@eshark9312 @thesan
Update packages/ui/src/validators/hooks/useValidatorsList.tsx
53b324f 
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
thesan
thesan approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There's still some talks on Discord about APRs/APYs but I think it's best to merge this now. If some follow ups are needed it should be done in another PR.

Nice work 👍

@thesan thesan merged commit 10f1ce6 into Joystream:validators Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eshark9312 @kdembler @thesan