Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦊 Metamask integration POC #4835

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

🦊 Metamask integration POC #4835

wants to merge 4 commits into from

Conversation

thesan
Copy link
Member

@thesan thesan commented Apr 17, 2024

Demo

  • @chainsafe/polkadot-snap fails on FF for me so the demo only works on Chrome based browsers AFAIK.
  • The demo points at my publish version of the snap, so it only works with Metamask Flask.
  • The snap works with HTTP RPC endpoints only (adding WS support is a headache). So the Apps implementing this should start storing the HTTP RPC link too. In the meantime it works with a simple text replacement hack.

For these reasons I'm keeping this PR as a draft (also the snap needs a bit more changes IMO).

@thesan thesan requested a review from kdembler April 17, 2024 16:41
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview May 1, 2024 1:07pm
pioneer-2 ✅ Ready (Inspect) Visit Preview May 1, 2024 1:07pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview May 1, 2024 1:07pm

@thesan thesan marked this pull request as draft April 17, 2024 16:43
@thesan
Copy link
Member Author

thesan commented Apr 26, 2024

@kdembler the official snap seems to work now but it still reports an error when connecting. Also I it might have been working before the last release, but I was focussed on this error before realizing that the wsRpcUrl should actually be the http rpc url 😕.

I reported the issue (with the error message): ChainSafe/metamask-snap-polkadot#231

Going forward:

  • Some more QA is needed especially with the real (i.e not flask) Metamask and with extrinsics that are Joystream specific.
  • The apps supporting this should store the http rpc endpoints in addition to the ws one.
  • Also maybe this should be enabled on Chrome based browser only for now. I had forgotten about this and got confused on FF today 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant