Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor incoming trades #3201

Merged
merged 4 commits into from
May 28, 2024
Merged

Monitor incoming trades #3201

merged 4 commits into from
May 28, 2024

Conversation

Abrynos
Copy link
Contributor

@Abrynos Abrynos commented May 4, 2024

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

As requested on our community Discord server.

New functionality

Metrics endpoint now provides information about trades received since last ASF restart.

Changed functionality

None

Removed functionality

None

Additional info

I do not want to include too much information (e.g. which items [marketable, rarity, appid, type, assetid, classid, contextid] were traded) due to performance/memory considerations. As soon as we start adding those details, this will quickly get out of hand.

Thank you for considering the inclusion of this merge request.

@Abrynos Abrynos marked this pull request as draft May 4, 2024 23:24
@Abrynos
Copy link
Contributor Author

Abrynos commented May 4, 2024

Draft, as I am not completely sure about this feature. Waiting for feedback before marking as ready for review.

@Abrynos Abrynos added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels May 4, 2024
@JustArchi JustArchi added 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels May 5, 2024
JustArchi
JustArchi approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, convert to normal PR when ready to merge @Abrynos

@Abrynos
Copy link
Contributor Author

Abrynos commented May 28, 2024

The little feedback I've received so far was positive so I guess if no one else is going to review, we can merge.

@Abrynos Abrynos marked this pull request as ready for review May 28, 2024 17:02
@JustArchi JustArchi added 🏁 Finished Issues marked with this label were finished already and no further work is required on them. and removed 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. labels May 28, 2024
@JustArchi
Copy link
Member

Thanks! 🏆

@JustArchi JustArchi merged commit 668bf50 into JustArchiNET:main May 28, 2024
20 checks passed
@Abrynos Abrynos deleted the monitor-incoming-trades branch May 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abrynos @JustArchi