Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sgl/flex porting #256

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Sgl/flex porting #256

wants to merge 6 commits into from

Conversation

sgliner-ledger
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (e6b45ad) to head (170d219).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #256   +/-   ##
========================================
  Coverage    84.85%   84.85%           
========================================
  Files           17       17           
  Lines         2192     2192           
========================================
  Hits          1860     1860           
  Misses         332      332           
Flag Coverage Δ
unittests 84.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgliner-ledger sgliner-ledger force-pushed the sgl/flex-porting branch 2 times, most recently from e04b200 to 3a74a80 Compare April 17, 2024 15:06
@sgliner-ledger sgliner-ledger force-pushed the sgl/flex-porting branch 11 times, most recently from fd94a47 to ac70a29 Compare April 26, 2024 12:47
@sgliner-ledger sgliner-ledger marked this pull request as ready for review April 26, 2024 12:48
src/ui/menu_nbgl.c Outdated Show resolved Hide resolved
NULL,
&infoList,
NULL,
exit);
}

void ui_menu_main_flow_bitcoin_testnet(void) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appname is set to Bitcoin Test and we want the homescreen to read bitcoin testnet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this will be done automatically now that ui_menu_main_flow_bitcoin uses APPNAME.

Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants