B2CA-1522: Add sender field in transaction #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/add_sender_field
branch
5 times, most recently
from
6bcb4bc
to
9cffc23
Compare
cedelavergne-ledger
force-pushed
the
cev/add_sender_field
branch
from
9cffc23
to
fa0dd67
Compare
Wiz Scan Summary
|
cedelavergne-ledger
force-pushed
the
cev/add_sender_field
branch
2 times, most recently
from
171fd90
to
9da6b90
Compare
cedelavergne-ledger
force-pushed
the
cev/add_sender_field
branch
from
9da6b90
to
12f881d
Compare
| // Transaction parameters are managed by the Exchange caller app! | ||
| explicit_bzero(strings.common.fromAddress, sizeof(strings.common.fromAddress)); | ||
| } else { | ||
| // Format the from address in a temporary buffer, if in swap case compare it with |
There was a problem hiding this comment.
Comment seems off ?
|
|
||
| if firmware.device == "nanos": | ||
| pytest.skip("Not supported on LNS") | ||
| challenge = app_client.get_challenge() | ||
| return ResponseParser.challenge(challenge.data) | ||
|
|
||
|
|
||
| def common_nav(firmware: Firmware, |
There was a problem hiding this comment.
If you want you can use the simple navigation helper from ragger. It does just that
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the
Tofield, add theFromto ease the transaction addresses reviewsDescription
Add new field in the structure
Add new field in the ValuePair review information
Update tests and screenshots
Changes include