Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 empty array handling fix #559

Merged
merged 8 commits into from
May 3, 2024
Merged

EIP-712 empty array handling fix #559

merged 8 commits into from
May 3, 2024

Commits on May 2, 2024

  1. Added problematic JSON file 

    LedgerHQ/ledger-live#6065
    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    46880bd View commit details
    Browse the repository at this point in the history

  2. Delay EIP-712 array traversal until size is received

    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    04464c2 View commit details
    Browse the repository at this point in the history

  3. Changed how EIP-712 array progression is counted

    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3be9e1d View commit details
    Browse the repository at this point in the history

  4. Improve EIP712 empty array test

    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    01f9db4 View commit details
    Browse the repository at this point in the history

  5. EIP-712 empty array handling fix

    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6df0ad5 View commit details
    Browse the repository at this point in the history

  6. Now uses Web3 to check EIP-712 signatures in Ragger tests 

    Fixed platformFeeRecipient address length in 14-rabby_bug-data.json since Web3 does not handle addresses with a length != 20B
    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a2107b8 View commit details
    Browse the repository at this point in the history

  7. Normalizes EIP-712 fixed-length bytes in Ragger client 

    Also some type-hinting and simplified the integer encoding
    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    02efe1d View commit details
    Browse the repository at this point in the history

  8. Updated client changelog

    @apaillier-ledger
    apaillier-ledger committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e7e1927 View commit details
    Browse the repository at this point in the history