Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ETH_PLUGIN_RESULT_OK_ALIAS from plugin API #574

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove deprecated ETH_PLUGIN_RESULT_OK_ALIAS from plugin API #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions doc/ethapp_plugins.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ typedef struct ethPluginInitContract_t {
uint8_t *selector; // 4 bytes selector
uint32_t dataSize;

char *alias; // 29 bytes alias if ETH_PLUGIN_RESULT_OK_ALIAS set

uint8_t result;

} ethPluginInitContract_t;
Expand All @@ -102,7 +100,6 @@ This message is sent when the selector of the data has been parsed. The followin
The following return codes are expected, any other will abort the signing process :

* ETH_PLUGIN_RESULT_OK : if the plugin can be successfully initialized
* ETH_PLUGIN_RESULT_OK_ALIAS : if a base64 encoded alias of another plugin to call is copied to the _alias_ field. In this case, the dispatcher will follow the alias chain, and the original plugin will only be called to retrieve its name when using a generic user interface
* ETH_PLUGIN_RESULT_FALLBACK : if the signing logic should fallback to the generic one

### ETH_PLUGIN_PROVIDE_PARAMETER
Expand Down
1 change: 0 additions & 1 deletion src/eth_plugin_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ eth_plugin_result_t eth_plugin_call(int method, void *parameter) {
(uint8_t *) &dataContext.tokenContext.pluginContext;
((ethPluginInitContract_t *) parameter)->pluginContextLength =
sizeof(dataContext.tokenContext.pluginContext);
((ethPluginInitContract_t *) parameter)->alias = dataContext.tokenContext.pluginName;
break;
case ETH_PLUGIN_PROVIDE_PARAMETER:
PRINTF("-- PLUGIN PROVIDE PARAMETER --\n");
Expand Down