Remove pluginSharedRW and pluginSharedRO from plugin API #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeutin-ledger
changed the base branch from
develop
to
fbe/remove_ETH_PLUGIN_RESULT_OK_ALIAS
fbeutin-ledger
force-pushed
the
fbe/remove_sha3_from_plugin_api
branch
2 times, most recently
from
5457ace
to
052b06d
Compare
fbeutin-ledger
force-pushed
the
fbe/remove_sha3_from_plugin_api
branch
from
052b06d
to
d467248
Compare
| const uint8_t *amount; // set an uint256 pointer if uiType is UI_AMOUNT_ADDRESS | ||
| const uint8_t *address; // set to the destination address if uiType is UI_AMOUNT_ADDRESS. | ||
| // set to the user's address if uiType is UI_TYPE_GENERIC | ||
| uint8_t numScreens; // set the number of screens to display if uiType is UI_TYPE_GENERIC |
There was a problem hiding this comment.
Could these fields managed inside a union (they seem to be exclusive)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.