Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements in Exchange app before Stax porting #107

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

fbeutin-ledger
Copy link
Contributor

@fbeutin-ledger fbeutin-ledger commented Apr 19, 2023

Remove context parameter being passed everywhere
Remove useless features like send function and handler callbacks
Factorize validation globals in global context
Split UI code from logic code
Fix const compilation warning issues

src/command_dispatcher.c Fixed Show fixed Hide fixed
src/start_new_transaction.c Fixed Show fixed Hide fixed
@fbeutin-ledger fbeutin-ledger force-pushed the fbe/improve_exchange_app branch 4 times, most recently from f1b7509 to 8708faa Compare April 20, 2023 08:22
lpascal-ledger
lpascal-ledger previously approved these changes Apr 20, 2023
Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. The rate additional check should be added in the CHANGELOG.

src/command_dispatcher.c Outdated Show resolved Hide resolved
Remove useless features like send function and handler callbacks
Factorize validation globals in global context
@fbeutin-ledger fbeutin-ledger merged commit b11678e into develop Apr 20, 2023
51 checks passed
@fbeutin-ledger fbeutin-ledger deleted the fbe/improve_exchange_app branch April 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants