Write spec for new PROMPT_UI_DISPLAY command #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeutin-ledger
force-pushed
the
fbe/split_check_from_ui_display
branch
4 times, most recently
from
79a75d4
to
5ed169b
Compare
|
PR is clean and can be review commit by commit |
fbeutin-ledger
force-pushed
the
fbe/split_check_from_ui_display
branch
2 times, most recently
from
484cb6b
to
defae2c
Compare
cpellizzari-ledger
approved these changes
May 7, 2024
fbeutin-ledger
force-pushed
the
fbe/split_check_from_ui_display
branch
3 times, most recently
from
3020e37
to
bb41ecf
Compare
… checks Add companion APDUs CHECK_ASSET_IN_NO_DISPLAY and CHECK_REFUND_ADDRESS_NO_DISPLAY Clarify CHECK_ASSET_IN as the replacement of deprecated CHECK_ASSET_IN_LEGACY for LEGACY flows too Move FUND_LEGACY and SELL_LEGACY tests to use CHECK_ASSET_IN instead of CHECK_ASSET_IN_LEGACY Add dedicated tests for CHECK_ASSET_IN_LEGACY Move lib tests to use PROMPT_UI_DISPLAY Add dedicated tests for CHECK_ASSET_X_AND_DISPLAY
fbeutin-ledger
force-pushed
the
fbe/split_check_from_ui_display
branch
from
bb41ecf
to
3ac7886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.