feat: update developer portal for swap #173
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -254,6 +264,9 @@ components: | |||
| nonce: | |||
| type: string | |||
| description: value to use for `device_transaction_id_ng` field in the protobuf payload. It will be an hex format of the byte array nonce received by the user. | |||
| slippage: | |||
| type: string | |||
| description: Value between 0 to 1 (0.1 => 10%) to describe the difference between the quote and the real value of the exchange | |||
There was a problem hiding this comment.
"to describe the difference between the quote and the real value of the exchange"
-> "maximum difference between the amount the user has seen in his quote and the amount he might finally receive, as a ratio of the quoted amount. Otherwise, the user should be asked for his consent to the new trade or reimbursed in original coin."
There was a problem hiding this comment.
this should not be a mandatory field
There was a problem hiding this comment.
not in required section ^^
There was a problem hiding this comment.
please use "Value between 0 to 1 (0.1 => 10%). Maximum difference between the amount the user has seen in his quote and the amount he might finally receive, as a ratio of the quoted amount. Otherwise, the user should be asked for his consent to the new trade or reimbursed in original coin."
Here and on defaultSlippage field bellow.
| @@ -307,6 +320,9 @@ components: | |||
| maxAmountFrom: | |||
| type: string | |||
| description: maximum valid `amount` for this pair (optional, only required if amount is too large) | |||
| slippage: | |||
| type: string | |||
| description: Value between 0 to 1 (0.1 => 10%) to describe the difference between the quote and the real value of the exchange | |||
There was a problem hiding this comment.
(same slippage description than above)
There was a problem hiding this comment.
we should have 2 fields :
- defaultSlippage -> default slippage value (will be used as a default setting to the user)
- slippageRange -> the user will be able to change slippage in this range. Ex : 0.01-0.3
There was a problem hiding this comment.
This leaves too much room for interpretation actually... Let's replace slippageRange with 2 fields, minSlippage (string, ex "0.01") and maxSlippage (string, ex "0.3") instead. sorry...
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
2 times, most recently
from
a21203d
to
8b9403b
Compare
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
from
8b9403b
to
5498a3c
Compare
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
from
5498a3c
to
deb5dc9
Compare
| @@ -307,6 +320,9 @@ components: | |||
| maxAmountFrom: | |||
| type: string | |||
| description: maximum valid `amount` for this pair (optional, only required if amount is too large) | |||
| slippage: | |||
| type: string | |||
| description: Value between 0 to 1 (0.1 => 10%) to describe the difference between the quote and the real value of the exchange | |||
There was a problem hiding this comment.
This leaves too much room for interpretation actually... Let's replace slippageRange with 2 fields, minSlippage (string, ex "0.01") and maxSlippage (string, ex "0.3") instead. sorry...
| @@ -254,6 +264,9 @@ components: | |||
| nonce: | |||
| type: string | |||
| description: value to use for `device_transaction_id_ng` field in the protobuf payload. It will be an hex format of the byte array nonce received by the user. | |||
| slippage: | |||
| type: string | |||
| description: Value between 0 to 1 (0.1 => 10%) to describe the difference between the quote and the real value of the exchange | |||
There was a problem hiding this comment.
please use "Value between 0 to 1 (0.1 => 10%). Maximum difference between the amount the user has seen in his quote and the amount he might finally receive, as a ratio of the quoted amount. Otherwise, the user should be asked for his consent to the new trade or reimbursed in original coin."
Here and on defaultSlippage field bellow.
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
from
dde4167
to
f6ec946
Compare
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
from
f6ec946
to
9cf29e6
Compare
tsouchon-ledger
force-pushed
the
update-delevoper-portal-for-swap
branch
from
9cf29e6
to
e0a4a23
Compare
No description provided.