Fix: LIVE-12068 [cosmos]Adapt LL code to avoid using deprecated endpoints #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
...edger-live-common/src/families/cosmos/datasets/__snapshots__/cosmos.integration.test.ts.snap
Outdated
Show resolved
Hide resolved
hedi-edelbloute
previously approved these changes
May 2, 2024
lambertkevin
reviewed
May 6, 2024
Comment on lines
+6
to
+14
| export const getMainMessage = (messages: CosmosEventMessage[]): CosmosEventMessage => { | ||
| const messagePriorities: string[] = [ | ||
| "unbond", | ||
| "redelegate", | ||
| "delegate", | ||
| "withdraw_rewards", | ||
| "transfer", | ||
| "MsgUndelegate", | ||
| "MsgBeginRedelegate", | ||
| "MsgDelegate", | ||
| "MsgWithdrawDelegatorReward", | ||
| "MsgTransfer", | ||
| "MsgRecvPacket", | ||
| "MsgSend", |
lambertkevin
reviewed
May 6, 2024
There was a problem hiding this comment.
Maybe I missed it, but I don't think we have a test checking that with a node on v0.50 we use a different URI ?
lambertkevin
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Since sdk 0.50, the GetTxsEvent will use "query" param instead of "event", see https://docs.cosmos.network/api#tag/Service/operation/GetTxsEvent for more details.
So, we should firstly check the cosmos sdk version and use query/event according to different cosmos sdk version.
Since sdk 0.50, the GetTxsEvent endpoint returns empty "logs"(a field in the GetTxsEvent api response). so we can't use logs to retrieve transactions any more. We should use "tx.body.messages" from now on.
Fixed regression:
For example, dydx and dydx testnet upgrade the cosmos SDK to 0.50 recently. So, the current codebase doesn't work with them.
Here is an example:
https://testnet-dydx-api.lavenderfive.com/cosmos/tx/v1beta1/txs?query=message.sender=%27dydx1pax8j79vm78qqvsnd5maklujqxahqm6j6r2mkl%27&pagination.limit=100&pagination.offset=0&pagination.reverse=true
as we can see that the "logs" array is always empty in the response.
❓ Context
🧐 Checklist for the PR Reviewers