New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: LIVE-11803 - rename device broken if an app is open #6773
Draft
valpinkman
wants to merge
2
commits into
develop
Choose a base branch
from
bugfix/LIVE-11803-quit-app-before-rename
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
aussedatlo
previously approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
jdabbech-ledger
previously approved these changes
Apr 29, 2024
valpinkman
dismissed stale reviews from jdabbech-ledger and aussedatlo
via
April 29, 2024 16:28
4d48cd7
valpinkman
force-pushed
the
bugfix/LIVE-11803-quit-app-before-rename
branch
from
April 29, 2024 16:28
3073694
to
4d48cd7
Compare
valpinkman
force-pushed
the
bugfix/LIVE-11803-quit-app-before-rename
branch
from
April 30, 2024 08:10
4d48cd7
to
cdb2fc9
Compare
jiyuzhuang
previously approved these changes
Apr 30, 2024
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
This bugfix adds the quitApp action before launching the renameDevice flow, thus removing the broken behavior is the user opened an app while the rename device modal is open.
I went with proposal 1 in the ticket, we could have also decided to make the error a bit more explicit but I believe this is a better UX
β Context
π§ Checklist for the PR Reviewers