Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: LIVE-11803 - rename device broken if an app is open #6773

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Apr 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • renameDevice in live-common to start with a quitApp

πŸ“ Description

This bugfix adds the quitApp action before launching the renameDevice flow, thus removing the broken behavior is the user opened an app while the rename device modal is open.

I went with proposal 1 in the ticket, we could have also decided to make the error a bit more explicit but I believe this is a better UX

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@valpinkman valpinkman requested a review from a team as a code owner April 29, 2024 14:19
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 30, 2024 4:03pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:03pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:03pm

aussedatlo
aussedatlo previously approved these changes Apr 29, 2024
Copy link
Contributor

@aussedatlo aussedatlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

jiyuzhuang
jiyuzhuang previously approved these changes Apr 30, 2024
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants