Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: add LL token icon #6776

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

shaynos
Copy link

@shaynos shaynos commented Apr 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Icon added only

πŸ“ Description

Add icon for LightLink ERC20 to Ledger
Network: Ethereum Mainnet
Contract Address: 0x0921799CB1d702148131024d18fCdE022129Dc73
Etherscan: https://etherscan.io/address/0x0921799CB1d702148131024d18fCdE022129Dc73

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@shaynos shaynos requested a review from a team as a code owner April 29, 2024 23:47
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 16, 2024 5:24am
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 16, 2024 5:24am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 5:24am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 5:24am

Copy link

vercel bot commented Apr 29, 2024

@shaynos is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added ui Has changes in the design system library fork Pull request base branch comes from a fork. labels Apr 29, 2024
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running pnpm install on this branch seems to reveal a problem on the importing of that icon

 src/native/LL.tsx:13:85 - error TS2322: Type '{ className: string; d: string; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Path…
β”‚   Property 'className' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Path> & Readonly<PathProps>'.
β”‚ 13   return <Svg viewBox="0 0 1200 1200" height={size} width={size} fill={color}><Path className="prefix__st0" d="M515.156 608.41c-15.329 15.328-15.329 40.774 …
β”‚                                                                                        ~~~~~~~~~
β”‚ Found 1 error in src/native/LL.tsx:13
β”‚  ELIFECYCLE  Command failed with exit code 2.
└─ Failed in 21.1s at /Users/grenaudeau/dev/ledger-live/libs/ui/packages/crypto-icons

@shaynos
Copy link
Author

shaynos commented Apr 30, 2024

Thanks @gre I've cleaned up the svg, looks like it builds ok now

@shaynos
Copy link
Author

shaynos commented May 6, 2024

Hi @gre friendly reminder on this pr pls

@gre
Copy link
Contributor

gre commented May 14, 2024

Hey @shaynos , sorry for the delay.
svg looks ok.
at the moment I don't see the LightLink token at all in our ERC20 lists ( https://support.ledger.com/hc/en-us/articles/10479755500573-Supported-Coins-and-Tokens-in-Ledger-Live?docs=true ), did you request it yet via https://developers.ledger.com/docs/tokens/integrating-tokens/evm-chains-tokens ?

thanks

@shaynos
Copy link
Author

shaynos commented May 16, 2024

Hey @gre no worries - Yes I requested the addition of LightLink token about 2 weeks ago via type form on the provided link. Is there any other actions we need to take?

Syncing this now with ledger branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork. ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants