Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LIVE-10131): swap tron swapping issue with other pairs than eth and edge cases to investigate #6778

Merged
merged 8 commits into from May 14, 2024
Merged

feat(LIVE-10131): swap tron swapping issue with other pairs than eth and edge cases to investigate #6778

merged 8 commits into from May 14, 2024

Conversation

cng-ledger
Copy link
Contributor

@cng-ledger cng-ledger commented Apr 30, 2024 •
edited by jira bot

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Updating token signatures for tron swap re-test

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cng-ledger cng-ledger requested a review from a team as a code owner April 30, 2024 07:40
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:44am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:44am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:44am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:44am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:44am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Apr 30, 2024
@ledger-wiz-cspm-secret-detection
Copy link

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 4L 0I
Total 0C 0H 0M 4L 0I
Secrets 0🔑

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Apr 30, 2024 •
edited

Mobile Bundle Checks

Comparing 1ae6071 against 62ac935.

⚠️ main.ios.jsbundle bundle size significantly increased: 59mb -> 59.6mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 59mb -> 59.6mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 1ae6071 against 62ac935.

⚠️ renderer bundle size significantly increased: 37.1mb -> 37.7mb. Please check if this is expected.

@cng-ledger
Merge branch 'develop' into LIVE-10131-swap-tron-swapping-issue-with-…
6b5ca5c 
…other-pairs-than-eth-and-edge-cases-to-investigate
@cng-ledger cng-ledger requested a review from a team as a code owner May 9, 2024 10:58
@live-github-bot live-github-bot bot added the common Has changes in live-common label May 9, 2024
gre
gre approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for hub scope

@cng-ledger cng-ledger merged commit 4499990 into develop May 14, 2024
58 checks passed
@cng-ledger cng-ledger deleted the LIVE-10131-swap-tron-swapping-issue-with-other-pairs-than-eth-and-edge-cases-to-investigate branch May 14, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

@lambertkevin lambertkevin lambertkevin approved these changes

@kallen-ledger kallen-ledger kallen-ledger approved these changes

Assignees

@cng-ledger cng-ledger

Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cng-ledger @gre @lambertkevin @kallen-ledger