[LLD] - [LIVE-12264] - Add Wallet Sync activation screen #6782
+221
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
sshmaxime
force-pushed
the
feat/LIVE-12264
branch
from
29e5925
to
21a9128
Compare
KVNLS
requested changes
Apr 30, 2024
apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
KVNLS
requested changes
Apr 30, 2024
apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
mcayuelas-ledger
requested changes
Apr 30, 2024
apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/settings/sections/General/WalletSyncRow.tsx
Outdated
Show resolved
Hide resolved
|
On the ticket |
|
More generally, I think that we should start to write our Integration tests now for Wallet Sync. |
sshmaxime
force-pushed
the
feat/LIVE-12264
branch
from
21a9128
to
443e92d
Compare
|
|
||
| const WalletSyncRow = () => { | ||
| const lldWalletSync = useFeature("lldWalletSync"); | ||
|
|
||
| const walletSync = useSelector(walletSyncSelector); |
There was a problem hiding this comment.
you can create a selector for activated only, in order to not "export" all the state
There was a problem hiding this comment.
Felt like it wasn't necessary right now.
KVNLS
requested changes
May 14, 2024
| "cta": "Create a backup" | ||
| }, | ||
| "alreadySync": { | ||
| "title": "Already created a back-up on another Device ?", |
There was a problem hiding this comment.
Suggested change
| "title": "Already created a back-up on another Device ?", | |
| "title": "Already created a back-up on another Device?", |
Comment on lines
41
to
43
| <LogoWrapper> | ||
| <Icons.Refresh size="L" color={colors.constant.purple} /> | ||
| </LogoWrapper> |
There was a problem hiding this comment.
This icon should not have 70% opacity.
sshmaxime
force-pushed
the
feat/LIVE-12264
branch
3 times, most recently
from
285fe06
to
9343252
Compare
sshmaxime
force-pushed
the
feat/LIVE-12264
branch
2 times, most recently
from
90d89f5
to
1c4baf8
Compare
mcayuelas-ledger
force-pushed
the
feat/LIVE-12264
branch
from
1c4baf8
to
7930a6b
Compare
sshmaxime
force-pushed
the
feat/LIVE-12264
branch
from
7930a6b
to
027ef52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This PR adds the Wallet Sync activation screen on LLD.
Note: It is missing shadows on the icons.
❓ Context
🧐 Checklist for the PR Reviewers