Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/stacks] Optimistic operation disappears for long running transactions #6793

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

lawRathod
Copy link
Contributor

@lawRathod lawRathod commented May 1, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The optimistics transaction disappears when transactions on stacks network takes long time. The pending operations are now added to accounts object during sync to fix the problem.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lawRathod lawRathod requested a review from a team as a code owner May 1, 2024 10:09
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 10:09am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 10:09am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 10:09am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 10:09am

Copy link

vercel bot commented May 1, 2024

@lawRathod is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added common Has changes in live-common fork Pull request base branch comes from a fork. labels May 1, 2024
@lawRathod lawRathod changed the title Fix/stacks pending [Fix/stacks] Optimistic operation disappears for long running transactions May 1, 2024
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common fork Pull request base branch comes from a fork. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant