Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proposition to integrate userData #6804

Conversation

sprohaszka-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

sentry-io bot commented May 3, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: libs/coin-framework/src/serialization/account.ts

Function Unhandled Issue
toAccountRaw RangeError: Invalid time value toAccountRaw(libs/...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 3, 2024
...commonAccountRaw,
name,
starred,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour éviter de spread les objets, je pense le réécrire en impératif, aussi je pense que dans un style impératif, il ne sera pas necessaire d'inject le toTokenAccount, on peut juste avoir une loop sur subAccounts qui va set les champs en plus de ceux qui sont set par commonToAccountRaw

si tu es ok avec l'idée je vais un peu rework ça, mais sinon pour le reste je suis ok avec ce déplacement de code

@gre gre force-pushed the support/account-model-decoupling branch 6 times, most recently from 4cd5f96 to b2c2f84 Compare May 6, 2024 10:19
@sprohaszka-ledger sprohaszka-ledger deleted the support/account-model-decoupling-stp branch May 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants