Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add xahau xah #6807

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feat/add xahau xah #6807

wants to merge 3 commits into from
+18,558 −17,945

Conversation

WietseWind
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • This adds Xahau network - https://xahau.network, an XRP Ledger (Ripple) protocol network, adding smart contract functionality
    • Changes to the repository are complete, tested (both desktop and mobile client) & re-use as much code as possible from the XRPL (Ripple) implementation (to prevent duplicate code)
    • It replaces the ripple-binary-codec with a network-independent version of the lib. as used in the XRPL ecosystem
    • This PR comes from XRPL Labs, bo te considered the primary external contributor in the XRPL ecosystem, maintainer of used package
    • This PR adds to the audit process (already started) for a Ledger XAH-app (in progress, working, tested, submitted @ Ledger for review, audit, etc.)

📝 Description

The XRP Ledger (Ripple) has another network in its ecosystem, called Xahau, which is XRP Ledger protocol but with native smart contracts added, and some new transaction types. There's overlap in the ecosystem, but the networks are separate.

This PR adds Xahau network and the native XAH asset to the Ledger Live Desktop and Mobile client, while keeping the libs used as much common to support both networks as possible.

❓ Context

Xahau/app-xah#1

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@WietseWind
Add Xahau XAH support
4e7d805 
commit 1756f14
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:17:00 2024 +0200

    Pass currency to submit operation and use to select network

commit cba95db
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:06:09 2024 +0200

    Import encode from binary codec for XRPL & Xahau (mjs)

commit 55dc3db
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:28 2024 +0200

    Remove debug logging

commit d09117c
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:22 2024 +0200

    Respect network querying network info

commit e1868a2
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:05 2024 +0200

    Allow for XRPL/Xahauu RPC endpoint based on object / string

commit b4028e3
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:59:47 2024 +0200

    Alias xahau as ripple-based protocol

commit c70f9d9
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:33:15 2024 +0200

    Add Xahau & XRPL explorers

commit fb9ca8f
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:33:09 2024 +0200

    Fix Xahau explorer

commit a3203dd
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:28:59 2024 +0200

    Add support for Xahau (alt XRPL Protocol) @ ripple family

commit 55a322c
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 14:46:32 2024 +0200

    XRPL Protocol = same BIP, normalise bridge

commit efb2c1a
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 14:46:12 2024 +0200

    appName = token code

commit 7839fda
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:42:19 2024 +0200

    abandonSeedAddresses for Xahau as well

commit 06eaf82
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:42:11 2024 +0200

    XRPL sister chains need different codec

commit bf8f0f2
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:38 2024 +0200

    Add XAH (Xahau) to supported currency list (mobile)

commit d028c01
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:25 2024 +0200

    Addh XAH app to common

commit aec4caf
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:04 2024 +0200

    Dependency: xrpl-binary-codec-prerelease to support XRPL & sister chains

commit 7716131
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 03:33:02 2024 +0200

    Prepare for TX on XRPL Protocol with NetworkID

commit 7d1dc6f
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:42 2024 +0200

    Add XAH app to readme

commit 0d991bc
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:31 2024 +0200

    hw-app-xah: multi chain binary codec

commit 929e4a5
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:14 2024 +0200

    ripple-binary-codec » xrpl-binary-codec for multi network support

commit 5a0bba3
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:53:50 2024 +0200

    ripple-binary-codec » xrpl-binary-codec

commit 0f642ae
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:53:11 2024 +0200

    Fix XAH readme

commit 30d3914
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 01:41:59 2024 +0200

    Add hw app XAH

commit 66abe9b
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:05:06 2024 +0200

    Add XAH mock

commit a396d9a
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:05:01 2024 +0200

    Add supported currency

commit a0662dc
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:04:52 2024 +0200

    Update network vs token name

commit cbfcddc
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:44:33 2024 +0200

    Xahau uses xrpl (ripple) family

commit ca44737
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:42:16 2024 +0200

    Adding XAH (Xahau network), SLIP # pending PR

commit 8eeedc9
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:41:08 2024 +0200

    Adding XAHAU RPC endpoint @ xahau.org

commit cb84700
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:40:55 2024 +0200

    CLI: tag (Destination Tag) = both XRPL & Xahau

commit e46f270
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:07:10 2024 +0200

    Add XAH icon
@WietseWind
Add Xahau XAH support
5a158fc 
commit 1756f14
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:17:00 2024 +0200

    Pass currency to submit operation and use to select network

commit cba95db
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:06:09 2024 +0200

    Import encode from binary codec for XRPL & Xahau (mjs)

commit 55dc3db
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:28 2024 +0200

    Remove debug logging

commit d09117c
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:22 2024 +0200

    Respect network querying network info

commit e1868a2
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 16:00:05 2024 +0200

    Allow for XRPL/Xahauu RPC endpoint based on object / string

commit b4028e3
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:59:47 2024 +0200

    Alias xahau as ripple-based protocol

commit c70f9d9
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:33:15 2024 +0200

    Add Xahau & XRPL explorers

commit fb9ca8f
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:33:09 2024 +0200

    Fix Xahau explorer

commit a3203dd
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 15:28:59 2024 +0200

    Add support for Xahau (alt XRPL Protocol) @ ripple family

commit 55a322c
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 14:46:32 2024 +0200

    XRPL Protocol = same BIP, normalise bridge

commit efb2c1a
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 14:46:12 2024 +0200

    appName = token code

commit 7839fda
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:42:19 2024 +0200

    abandonSeedAddresses for Xahau as well

commit 06eaf82
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:42:11 2024 +0200

    XRPL sister chains need different codec

commit bf8f0f2
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:38 2024 +0200

    Add XAH (Xahau) to supported currency list (mobile)

commit d028c01
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:25 2024 +0200

    Addh XAH app to common

commit aec4caf
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 13:41:04 2024 +0200

    Dependency: xrpl-binary-codec-prerelease to support XRPL & sister chains

commit 7716131
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 03:33:02 2024 +0200

    Prepare for TX on XRPL Protocol with NetworkID

commit 7d1dc6f
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:42 2024 +0200

    Add XAH app to readme

commit 0d991bc
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:31 2024 +0200

    hw-app-xah: multi chain binary codec

commit 929e4a5
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:54:14 2024 +0200

    ripple-binary-codec » xrpl-binary-codec for multi network support

commit 5a0bba3
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:53:50 2024 +0200

    ripple-binary-codec » xrpl-binary-codec

commit 0f642ae
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 02:53:11 2024 +0200

    Fix XAH readme

commit 30d3914
Author: Wietse Wind <mail@wietse.com>
Date:   Fri Apr 19 01:41:59 2024 +0200

    Add hw app XAH

commit 66abe9b
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:05:06 2024 +0200

    Add XAH mock

commit a396d9a
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:05:01 2024 +0200

    Add supported currency

commit a0662dc
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 17:04:52 2024 +0200

    Update network vs token name

commit cbfcddc
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:44:33 2024 +0200

    Xahau uses xrpl (ripple) family

commit ca44737
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:42:16 2024 +0200

    Adding XAH (Xahau network), SLIP # pending PR

commit 8eeedc9
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:41:08 2024 +0200

    Adding XAHAU RPC endpoint @ xahau.org

commit cb84700
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:40:55 2024 +0200

    CLI: tag (Destination Tag) = both XRPL & Xahau

commit e46f270
Author: Wietse Wind <mail@wietse.com>
Date:   Thu Apr 18 16:07:10 2024 +0200

    Add XAH icon
@WietseWind
Merge branch 'feat/add-xahau-xah' of github.com:Xahau/ledger-live int…
97c0c7b 
…o feat/add-xahau-xah

# Conflicts:
#	apps/ledger-live-desktop/cryptoassets.md
@WietseWind WietseWind requested review from a team as code owners May 3, 2024 21:45
@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:45pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:45pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:45pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 9:45pm

@vercel Vercel
Copy link

vercel bot commented May 3, 2024

@WietseWind is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs cli fork Pull request base branch comes from a fork. labels May 3, 2024
@ledger-wiz-cspm-secret-detection
Copy link

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 8L 0I
Total 0C 0H 0M 8L 0I
Secrets 0🔑

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/xrpl-binary-codec-prerelease@8.0.1 Transitive: eval +29 1.85 MB wietsewind

View full report↗︎

@github-actions GitHub Actions
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WietseWind WietseWind

Labels
cli common Has changes in live-common desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM Stale ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@WietseWind