Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix Firebase integration of CVS v3 rework #6811

Merged
merged 1 commit into from May 14, 2024
Merged

chore: fix Firebase integration of CVS v3 rework #6811

merged 1 commit into from May 14, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented May 6, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • make Firebase properly connected to CVS.

📝 Description

in #6771, I have used a wrong id to connect the live config CVS keys.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested a review from a team as a code owner May 6, 2024 14:04
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 1:41pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:41pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:41pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:41pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:41pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels May 6, 2024
@gre gre force-pushed the support/connect-remote-config-cvs-to-firebase branch from 62166d4 to b46b48a Compare May 10, 2024 08:01
@gre
Copy link
Contributor Author

gre commented May 10, 2024

it seems to consistently fail on LLM. will have to dig why.

@gre gre marked this pull request as draft May 10, 2024 09:48
@gre gre force-pushed the support/connect-remote-config-cvs-to-firebase branch from b46b48a to daf69c0 Compare May 10, 2024 14:57
mcayuelas-ledger
mcayuelas-ledger reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update

libs/ledger-live-common/src/config/sharedConfig.ts
No ?

@gre
Copy link
Contributor Author

gre commented May 13, 2024

@mcayuelas-ledger good catch, a bit scary that this lib is untyped.

@gre gre force-pushed the support/connect-remote-config-cvs-to-firebase branch from daf69c0 to d38aea3 Compare May 13, 2024 13:36
@live-github-bot live-github-bot bot added the common Has changes in live-common label May 13, 2024
@gre gre marked this pull request as ready for review May 13, 2024 15:38
@gre gre requested a review from mcayuelas-ledger May 13, 2024 15:38
@gre gre merged commit e8d9063 into develop May 14, 2024
60 checks passed
@gre gre deleted the support/connect-remote-config-cvs-to-firebase branch May 14, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@gre gre

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gre @mcayuelas-ledger