[Coin Modularization] Cardano #6812
Open
+1,401
−1,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
live-github-bot
bot
added
desktop
sprohaszka-ledger
force-pushed
the
feat/LIVE-8166-cardano
branch
from
00de9c9
to
5b48fc3
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
lvndry
reviewed
May 13, 2024
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
sprohaszka-ledger
force-pushed
the
feat/LIVE-8166-cardano
branch
from
5b48fc3
to
db91ef9
Compare
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
lvndry
previously approved these changes
May 17, 2024
lambertkevin
approved these changes
May 17, 2024
Comment on lines
+39
to
+137
| return { | ||
| getAddress: async ({ | ||
| path, | ||
| stakingPathString, | ||
| networkParams, | ||
| verify, | ||
| }: GetAddressRequest): Promise<CardanoAddress> => { | ||
| const network = | ||
| networkParams.networkId === Networks.Mainnet.networkId | ||
| ? Networks.Mainnet | ||
| : Networks.Testnet; | ||
|
|
||
| const r = await ada.deriveAddress({ | ||
| network, | ||
| address: { | ||
| type: AddressType.BASE_PAYMENT_KEY_STAKE_KEY, | ||
| params: { | ||
| spendingPath: str_to_path(path), | ||
| stakingPath: str_to_path(stakingPathString), | ||
| }, | ||
| }, | ||
| }); | ||
| if (verify) { | ||
| await ada.showAddress({ | ||
| network, | ||
| address: { | ||
| type: AddressType.BASE_PAYMENT_KEY_STAKE_KEY, | ||
| params: { | ||
| spendingPath: str_to_path(path), | ||
| stakingPath: str_to_path(stakingPathString), | ||
| }, | ||
| }, | ||
| }); | ||
| } | ||
| const address = TyphonUtils.getAddressFromHex(r.addressHex) as TyphonAddress.BaseAddress; | ||
| return { | ||
| address: address.getBech32(), | ||
| // Here, we use publicKey hash, as cardano app doesn't export the public key | ||
| publicKey: address.paymentCredential.hash, | ||
| }; | ||
| }, | ||
| getPublicKey: async (accountPath: string): Promise<CardanoExtendedPublicKey> => { | ||
| return ada.getExtendedPublicKey({ | ||
| path: str_to_path(accountPath), | ||
| }); | ||
| }, | ||
| sign: async ({ | ||
| unsignedTransaction, | ||
| accountPubKey, | ||
| accountIndex, | ||
| networkParams, | ||
| }: CardanoSignRequest): Promise<CardanoSignature> => { | ||
| const rawInputs = unsignedTransaction.getInputs(); | ||
| const ledgerAppInputs = rawInputs.map(i => prepareLedgerInput(i, accountIndex)); | ||
|
|
||
| const rawOutptus = unsignedTransaction.getOutputs(); | ||
| const ledgerAppOutputs = rawOutptus.map(o => prepareLedgerOutput(o, accountIndex)); | ||
|
|
||
| const rawCertificates = unsignedTransaction.getCertificates(); | ||
| const ledgerCertificates = rawCertificates.map(prepareCertificate); | ||
|
|
||
| const rawWithdrawals = unsignedTransaction.getWithdrawals(); | ||
| const ledgerWithdrawals = rawWithdrawals.map(prepareWithdrawal); | ||
|
|
||
| const auxiliaryDataHashHex = unsignedTransaction.getAuxiliaryDataHashHex(); | ||
|
|
||
| const network = | ||
| networkParams.networkId === Networks.Mainnet.networkId | ||
| ? Networks.Mainnet | ||
| : Networks.Testnet; | ||
|
|
||
| const trxOptions: SignTransactionRequest = { | ||
| signingMode: TransactionSigningMode.ORDINARY_TRANSACTION, | ||
| tx: { | ||
| network, | ||
| inputs: ledgerAppInputs, | ||
| outputs: ledgerAppOutputs, | ||
| certificates: ledgerCertificates, | ||
| withdrawals: ledgerWithdrawals, | ||
| fee: unsignedTransaction.getFee().toString(), | ||
| ttl: unsignedTransaction.getTTL()?.toString(), | ||
| validityIntervalStart: null, | ||
| auxiliaryData: auxiliaryDataHashHex | ||
| ? { | ||
| type: TxAuxiliaryDataType.ARBITRARY_HASH, | ||
| params: { | ||
| hashHex: auxiliaryDataHashHex, | ||
| }, | ||
| } | ||
| : null, | ||
| }, | ||
| additionalWitnessPaths: [], | ||
| }; | ||
|
|
||
| const r = await ada.signTransaction(trxOptions); | ||
| return signTx(unsignedTransaction, accountPubKey, r.witnesses); | ||
| }, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Feels kinda wrong to have that much coin logic into LLC don't you think ? 🤔
Really feels like the coin-module would be unusable without LLC here 🫤
Comment on lines
+1
to
+3
| export type { APIGetPoolsDetail, StakePool } from "@ledgerhq/coin-cardano/api/api-types"; | ||
| export { fetchPoolDetails } from "@ledgerhq/coin-cardano/api/getPools"; | ||
| export { LEDGER_POOL_IDS } from "@ledgerhq/coin-cardano/utils"; |
There was a problem hiding this comment.
Is this necessary ? Can't UI specific to Cardano simply get the types from @ledgerhq/coin-cardano directly ? Or do you specifically want that to be an entrypoint for those types & constants ?
There was a problem hiding this comment.
Same thing here I'm not quite sure to get why this should continue to live in LLC ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Move Cardano...
❓ Context
🧐 Checklist for the PR Reviewers