Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-api): align LLM prepareSignTransaction with LLD implementation [LIVE-12087] #6814

Merged
merged 3 commits into from
May 7, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented May 7, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM wallet-api and platform-sdk sign.transaction calls

📝 Description

Align LLM prepareSignTransaction with LLD implementation, the original PR is: #6759
We mainly remove the customGasLimit and type: 1 that doesn't seem to be used and instead rely on the convertToLiveTransaction to init everything as done in LLD

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this May 7, 2024
@Justkant Justkant requested a review from a team as a code owner May 7, 2024 07:19
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:40am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:40am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:40am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:40am
web-tools ⬜️ Ignored (Inspect) May 7, 2024 8:40am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 7, 2024
@live-github-bot live-github-bot bot added the common Has changes in live-common label May 7, 2024
@Justkant Justkant merged commit 0c2d840 into develop May 7, 2024
57 of 60 checks passed
@Justkant Justkant deleted the bugfix/LIVE-12087-llm-prepareSignTx branch May 7, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants