Unify linkscript for all targets #398
Conversation
yhql
force-pushed
the
single_linkscript
branch
2 times, most recently
from
092d171
to
abc172e
Compare
|
This is breaking app-bitcoin-new build on nanos, so probably something doesn't works as expected. |
|
I suppose it's because the |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 11 11
Lines 864 864
=======================================
Hits 597 597
Misses 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yes, I forgot the placement of G_cx. Moved it to the Nano S's layout only. |
There was a problem hiding this comment.
Not sure if it is really used but the "debug" part for each device has been dropped
There was a problem hiding this comment.
why you removed some comments? (some of them seem to be useful)
There was a problem hiding this comment.
I found those to be either invalid (or not valid anymore) or confusing
Description
We currently use one linker script per target that embeds the memory definitions and the placement of code sections in memory. The placement part is pretty similar across devices and has no reason to be kept duplicated.
This PR splits things into per-target memory definitions and a single
script.ldthat places code sections, and can be updated for all devices at once when we need it to.Perhaps even the memory definitions could be merged together also (in another PR).
Changes include
(cleanup/refactor)