Improve some widgets to add icon #530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/contol_with_icons
branch
from
3e5f549
to
4f2ce89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 12 12
Lines 1660 1660
=======================================
Hits 1003 1003
Misses 657 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
force-pushed
the
cev/contol_with_icons
branch
3 times, most recently
from
631efa6
to
a140bce
Compare
cedelavergne-ledger
force-pushed
the
cev/contol_with_icons
branch
3 times, most recently
from
610acb1
to
edb8c7a
Compare
- Allow text1 and text2, instead of text1 or text2 - Add icon between the QR Code and the text lines - Increase max layout children up tp 4 - Force QR Code V10 (smaller than V4) if icon and text1 and text2 are provided
cedelavergne-ledger
force-pushed
the
cev/contol_with_icons
branch
2 times, most recently
from
e848486
to
540dbf8
Compare
cedelavergne-ledger
force-pushed
the
cev/contol_with_icons
branch
from
540dbf8
to
ac955ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possibility to add icons on some widgets:
BARS_LIST_ICONSto have a left iconnbgl_layoutAddChoiceButtonsIconallowing an icon on the top buttonnbgl_pageDrawInfoIcon, callingnbgl_layoutAddChoiceButtonsIconnbgl_useCaseHomeExtIconto have an icon on theactionButtonChanges include