Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to add input data to AES-CMAC #642

Merged
merged 2 commits into from May 16, 2024

Conversation

srasoamiaramanana-ledger
Copy link
Contributor

Description

This PR allows to update the AES-CMAC context with a block of the plaintext for AES-SIV encryption/decryption.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (9969919) to head (79e1b35).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   59.92%   60.47%   +0.54%     
==========================================
  Files          12       12              
  Lines        1682     1723      +41     
==========================================
+ Hits         1008     1042      +34     
- Misses        674      681       +7     
Flag Coverage Δ
unittests 60.47% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jarevalo-ledger jarevalo-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srasoamiaramanana-ledger srasoamiaramanana-ledger merged commit e0d514f into master May 16, 2024
193 checks passed
@srasoamiaramanana-ledger srasoamiaramanana-ledger deleted the aes-siv-update-mac branch May 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants