Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split extended NFC APDUs into smaller seph messages #665

Merged
merged 3 commits into from
May 30, 2024

Conversation

yrichard-ledger
Copy link
Contributor

@yrichard-ledger yrichard-ledger commented May 16, 2024

Description

This PR splits extended NFC APDUs (>255 bytes) into smaller chunks that fit into internal bolos buffers when sending and receiving them over SEPH.
To perform the split we use the existing ledger protocol, like we do on BLE and USB.

Support for extended size APDUs is required for FIDO2 on NFC, with APDU sizes that can exceed 700 bytes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

The payload format of NFC_CAPDU and NFC_RAPDU seph messages is modified and it now includes a ledger protocol header

Additional comments

Release of this change must be synchronized with the release of the corresponding MCU firmware.

@yrichard-ledger yrichard-ledger force-pushed the yri_split_nfc_apdus branch 2 times, most recently from 17a28b6 to 3187eaf Compare May 16, 2024 15:57
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (2c7513a) to head (1546ce0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          12       12           
  Lines        1723     1723           
=======================================
  Hits         1042     1042           
  Misses        681      681           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrichard-ledger yrichard-ledger force-pushed the yri_split_nfc_apdus branch 2 times, most recently from 91665ee to 1546ce0 Compare May 23, 2024 07:30
@yrichard-ledger yrichard-ledger merged commit be085f3 into master May 30, 2024
193 checks passed
@yrichard-ledger yrichard-ledger deleted the yri_split_nfc_apdus branch May 30, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants