Split extended NFC APDUs into smaller seph messages #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits extended NFC APDUs (>255 bytes) into smaller chunks that fit into internal bolos buffers when sending and receiving them over SEPH.
To perform the split we use the existing ledger protocol, like we do on BLE and USB.
Support for extended size APDUs is required for FIDO2 on NFC, with APDU sizes that can exceed 700 bytes.
Changes include
Breaking changes
The payload format of NFC_CAPDU and NFC_RAPDU seph messages is modified and it now includes a ledger protocol header
Additional comments
Release of this change must be synchronized with the release of the corresponding MCU firmware.