Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): properly handle accessibility permission #2508

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hazer
Copy link
Member

@Hazer Hazer commented May 7, 2024

Description

Check for macOS Accessibility permission to allow mouse and keyboard input events to work properly.

  • Automatically includes sunshine to the Accessibility list in the Settings pane, no need to find out the binary path;
  • Shows prompt to user;
  • Logs to the user every time we receive an input event that won't execute because of missing accessibility permission.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 7.33%. Comparing base (c204b2c) to head (b05c75c).
Report is 1 commits behind head on master.

Current head b05c75c differs from pull request most recent head 062d1fb

Please upload reports for the commit 062d1fb to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2508      +/-   ##
=========================================
+ Coverage    7.03%   7.33%   +0.29%     
=========================================
  Files          87      66      -21     
  Lines       17697   12479    -5218     
  Branches     8406    6042    -2364     
=========================================
- Hits         1245     915     -330     
+ Misses      13870   10733    -3137     
+ Partials     2582     831    -1751     
Flag Coverage Δ
Linux 4.26% <ø> (-1.09%) ⬇️
Windows ?
macOS-12 8.58% <0.00%> (+0.53%) ⬆️
macOS-13 7.84% <0.00%> (-0.14%) ⬇️
macOS-14 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/platform/macos/misc.mm 6.25% <0.00%> (-0.75%) ⬇️
src/platform/macos/input.cpp 2.19% <0.00%> (-0.26%) ⬇️

... and 76 files with indirect coverage changes

@Hazer Hazer marked this pull request as draft May 7, 2024 15:02
@Hazer
Copy link
Member Author

Hazer commented May 7, 2024

Needs test coverage on the new methods

@Hazer
Copy link
Member Author

Hazer commented May 24, 2024

If we are going to test this, this has to be tested only on CI, this cannot be tested on macports test action.

@Hazer Hazer force-pushed the fix/macos-accessibility-request branch from 2340497 to 062d1fb Compare May 24, 2024 23:06
@Hazer
Copy link
Member Author

Hazer commented Jun 5, 2024

Waiting for #2550 to create the tests

@Hazer Hazer mentioned this pull request Jun 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant