Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change improve pages target #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bugsounet
Copy link
Contributor

Now, develop branch is online

So, let's change improve pages target to develop branch

@rejas
Copy link
Collaborator

rejas commented Sep 9, 2023

But what happens when we merge develop into the master branch?

@bugsounet
Copy link
Contributor Author

Try with a fork?

@rejas
Copy link
Collaborator

rejas commented Sep 10, 2023

But the develop branch can already be found here: https://develop.docs.magicmirror.builders/ so why the change?

@bugsounet
Copy link
Contributor Author

bugsounet commented Sep 10, 2023

because it's related to this target:

image

I think it's better to edit/modify any pages to the develop branch and not in master

Notes:

  • It will not read all source file in develop branch
  • It's will just change the "help us improve this page!" link
  • if npm start is started on the master branch, it will read master branch files

@rejas
Copy link
Collaborator

rejas commented Oct 16, 2023

I think it's better to edit/modify any pages to the develop branch and not in master

Not convinced that this is the use-case for this link. In my opinion, this link is for people that browse the webpage and want to fix a typo or some other error. They want to edit master.

If a developer wants to fix something (add new config options in an upcoming release for example) they would probably not use that link but rather go their normal way with their IDE of choice etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants