Fix weathergov api precipitationLastHour #3125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #3125 +/- ##
===========================================
+ Coverage 25.55% 25.61% +0.06%
===========================================
Files 53 53
Lines 11464 11464
===========================================
+ Hits 2930 2937 +7
+ Misses 8534 8527 -7
|
rejas
requested changes
Jun 17, 2023
| @@ -210,7 +210,7 @@ WeatherProvider.register("weathergov", { | |||
| currentWeather.minTemperature = currentWeatherData.minTemperatureLast24Hours.value; | |||
| currentWeather.maxTemperature = currentWeatherData.maxTemperatureLast24Hours.value; | |||
| currentWeather.humidity = Math.round(currentWeatherData.relativeHumidity.value); | |||
| currentWeather.precipitationAmount = currentWeatherData.precipitationLastHour.value; | |||
| currentWeather.precipitationAmount = currentWeatherData.precipitationLast3Hours.value; | |||
There was a problem hiding this comment.
Maybe use the 3hours info as a fallback in case the precipitationLastHour is undefined?
rejas
reviewed
Jul 13, 2023
| "dependencies": { | ||
| "colors": "^1.4.0", | ||
| "console-stamp": "^3.1.1", | ||
| "digest-fetch": "^2.0.3", | ||
| "electron": "^25.2.0", |
There was a problem hiding this comment.
electron should stay in the optional dependencies
|
@JasonStieber can you make the requested changes? |
|
pinging @JasonStieber in the hope he picks this PR up again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request fixes small big in weathergov api format mismatch #3124