Added Specific ignoreOlderThan value (override) per URL Feature, Issue #3360 #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be easier to add the variables for each feed and then use a function that returned the feed value or the default if not specified and use that function instead of the direct value access in the genersteFeed function |
…de a function that returned values from the feed
|
Hello, |
AartiPhatke
commented
Apr 27, 2024
| @@ -5,7 +5,9 @@ Module.register("newsfeed", { | |||
| { | |||
| title: "New York Times", | |||
| url: "https://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml", | |||
| encoding: "UTF-8" //ISO-8859-1 | |||
| encoding: "UTF-8", //ISO-8859-1 | |||
| ignoreOldItems: false, | |||
There was a problem hiding this comment.
Rather than having ignorOldItems and ignorOlderThan be global parameters, I added them inside the feed array and gave then default values of false and 1day.
AartiPhatke
commented
Apr 27, 2024
| @@ -176,19 +180,23 @@ Module.register("newsfeed", { | |||
| }); | |||
| } | |||
| }, | |||
|
|
|||
| getFeedProperty(feed, property) { | |||
There was a problem hiding this comment.
I added this function so you can access values inside the objects in the feed array.
AartiPhatke
commented
Apr 27, 2024
| for (let item of feedItems) { | ||
| item.sourceTitle = this.titleForFeed(feed); | ||
| if (!(this.config.ignoreOldItems && Date.now() - new Date(item.pubdate) > this.config.ignoreOlderThan)) { | ||
| let ignoreOldItems = getFeedProperty(feedItems, 'ignoreOldItems'); |
There was a problem hiding this comment.
I changed how the the variables are accessed when trying to display the feed by using the getFeedProperty()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added the feature request in the newsfeed module for being able to set ignoreOlderThan for each newsfeed rather than have a global variable for it. To do this however, instead of adding an ignoreOlderThanOveride parameter, I changed ignoreOldItems and ignoreOlderThan to be arrays so they can hold values for each news feed. I also changed the logic for how these variables are accessed in generateFeed(). I also ran 'npm run test' and some of the unit tests for the calendar module were failing, I don't think this is related to my PR but I wanted to mention it.
Hope this helps!