-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peertube support #782
base: main
Are you sure you want to change the base?
Add peertube support #782
Conversation
To be able to handle the activities peertube sends these things needed to be added: - extract the target magazine / group from the `attributedTo` property. It is an array with both the user and the channel (group) in it - handle array as `url` property - add `Video` as a supported entry type
I noticed that there are a lot of weird issues with the header signature from tilvids on my server (activities that are sent by them) and I want to investigate what the exact issue is there |
As far as I can see the signature problems only occur, because tilvids has their cdn on another subdomain, but sends stuff as if it would come from the original domain. That could of course be a problem and something we should look at in another issue/PR, but I don't think that it will be problematic for the general PeerTube support, as it only uses the cdn to deliver updates on |
As you can see it is working on GehirnEimer: But I have to switch branches there |
I asked for a better way to sync like/dislikes Chocobozzz/PeerTube#6400 |
To be able to handle the activities peertube sends these things needed to be added:
attributedTo
property. It is an array with both the user and the channel (group) in it. This is necessary, because the channel is not mentioned in theTo
orCc
fieldurl
propertyVideo
as a supported entry typeSupported interactions with peertube:
new video is posted
that is an incoming
Announce
activity, no problems there with this PRnew comment under a video is posted
a new comment under a video that we do not have on our server yet works with this PR
likes and dislikes
seem to be sent to other instances by sending an
Update
activity for the original post. In the json of the post there are collections forlikes
,dislikes
andshares
. So maybe we could support that in the future, but it feels very weird to me to fetch instead of getting them sent to me. Additionally the collection does not just contain the actor ids, but the id of theLike
/Dislike
activity. Since we do not save that we would have to fetch a lot on each update we get.Example activites pulled from TilVids
Create Activity (https://tilvids.com/videos/watch/1c97fd94-5fb3-45e5-ad65-b52b722a64f6)
Channel Actor (Group) (https://tilvids.com/video-channels/thelinuxexperiment_channel)
To test this you can just insert the url in the search field. That will trigger mbin to process the activity as if it was sent to us.
Closes #162