slight MentionManager robustness improvement #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobodyatroot
approved these changes
May 20, 2024
changed MentionManager::extract() to pass in value to process by function argument rather than shared private property of the service, makes the data flow clearer and prevent accidental state sharing also add unicode flag to mention regex matching in MentionManager to improve robustness when processing unicode text/matches, without this, the matched results may contain invalid unicode, and would result in 'Malformed UTF-8 characters, possibly incorrectly encoded' or similar errors when persisting entries/posts to database
asdfzdfj
force-pushed
the
fix/improve-mention-parsing-robustness
branch
from
67efeb1
to
c6a7687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed
MentionManager::extract()to pass in value to process by function argument rather than shared private property of the service, makes the data flow clearer and prevent accidental state sharingalso add unicode flag to mention regex matching in MentionManager to improve robustness when processing unicode text/matches, without this, the matched results may contain invalid unicode, and would result in 'Malformed UTF-8 characters, possibly incorrectly encoded' or similar errors when persisting entries/posts to database