Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1347 human readable confluence url #1434

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

cope
Copy link
Sponsor Contributor

@cope cope commented May 17, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #1362

What is in this change?

The baseUrl value for the human readable confluence url cannot have /wiki in it.

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@timothycarambat
Copy link
Member

@cope What is a URL example here for this? If the URL includes display it should get matched regardless, no?

@cope
Copy link
Sponsor Contributor Author

cope commented May 20, 2024

@timothycarambat the API url does not have display in it, similar to how the /wiki/space one does not have space.

In other words, for default https://domain.atlassian.net/wiki/space/~SPACEID/* the API url is only https://domain.atlassian.net/wiki/.

Similarly, for https://<customDomain>/display/~SPACEID/* the API url is only https://<customDomain>/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants