Add missing __builtin_clz definition for MSVC

[MasterDuke17]

It was missed when copying #defines from
https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/int_lib.h.

[MasterDuke17]

Huh, anybody have an idea what's happening here? https://dev.azure.com/MoarVM/MoarVM/_build/results?buildId=1423&view=logs&j=97945c8c-7ab8-5ec2-f2c7-7c8541d3bf5c&t=439f2dd7-104a-517a-a6b1-3f392bb69fda&l=2266

[timo]

do you know that the name exists in the dll for sure? maybe something changed somewhere. you should be able to use dumpbin.exe /ALL D:\a\1\rakudo\13-cpp-mangling.dll and dumpbin.exe /ALL D:\a\1\rakudo\11-cpp.dll and somewhere in there we should see the symbols we're not getting successfully

[MasterDuke17]

do you know that the name exists in the dll for sure? maybe something changed somewhere. you should be able to use dumpbin.exe /ALL D:\a\1\rakudo\13-cpp-mangling.dll and dumpbin.exe /ALL D:\a\1\rakudo\11-cpp.dll and somewhere in there we should see the symbols we're not getting successfully

I think the nativecall errors are unrelated to this change. But if you can explain https://dev.azure.com/MoarVM/MoarVM/_build/results?buildId=1436&view=logs&j=d36c29d8-9236-5cd5-d848-768a0b8a3eb3&t=d8ee4cfd-785a-54f9-bf7e-80664ee220b4&l=34 I would most grateful. If I pull our i64toa_jeaiii out into a separate file and run it with 1449334664 it's just fine. Is this a windows-only problem?

[MasterDuke17]

I think the nativecall errors are unrelated to this change. But if you can explain dev.azure.com/MoarVM/MoarVM/_build/results?buildId=1436&view=logs&j=d36c29d8-9236-5cd5-d848-768a0b8a3eb3&t=d8ee4cfd-785a-54f9-bf7e-80664ee220b4&l=34 I would most grateful. If I pull our i64toa_jeaiii out into a separate file and run it with 1449334664 it's just fine. Is this a windows-only problem?

And if I build this branch locally (with all the extra checks and debug fprintfs) it builds just fine without printing anything.

[patrickbkr]

The native call thing is tracked over in: rakudo/rakudo#5587, I'm pretty sure that's a different issue.

[timo]

i don't have the brain power right now to actually look deeply at anything, but this looks kind of suspicious?

but probably just something you put in for debugging purposes?

[MasterDuke17]

i don't have the brain power right now to actually look deeply at anything, but this looks kind of suspicious?

but probably just something you put in for debugging purposes?

Well, that definitely needs to be clarified, but it shouldn't be the cause. That's just to figure out how big of a string to allocate, but even writing into a definitely-big-enough stack-allocated string initialized to all 0 ends up wrong.

[timo]

not sure if this does anything, but try %lld instead of %ld in the printf, maybe that's causing a problem?

[timo]

yeah at least some of the numbers in the debug output are suspiciously 31 bits long and then a much longer number for the output of m and m2

[Cellesti]

Maybe this could be related. After finding some test failures in t/nqp/115-nums.t on 32-bit Alpine Linux, i too placed an fprintf in MVM_coerce_i_s (but i put it before the call to MVM_malloc).

What i found was, the tests sometime cause i to take on a value of -9223372036854775808 (INT64_MIN), which a few steps later causes mag[msb] to access past the end of mag.

I mentioned my observations with a bit more detail here.

[MasterDuke17]

Maybe this could be related. After finding some test failures in t/nqp/115-nums.t on 32-bit Alpine Linux, i too placed an fprintf in MVM_coerce_i_s (but i put it before the call to MVM_malloc).

What i found was, the tests sometime cause i to take on a value of -9223372036854775808 (INT64_MIN), which a few steps later causes mag[msb] to access past the end of mag.

I mentioned my observations with a bit more detail here.

This is probably helpful information, thanks.

I wonder if we can easily add 32-bit Alpine Linux to our CI pipeline?

[Cellesti]

Alpine itself uses Gitlab for CI, which is where i first noticed this issue, while trying to upgrade Rakudo and its dependencies.

As for Github, an Alpine developer has this project which you may find helpful: https://github.com/jirutka/setup-alpine