feat(server): [nan-869] email verification on signup #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
May 20, 2024
packages/server/lib/controllers/v1/account/resendVerificationEmail.ts
Outdated
Show resolved
Hide resolved
…-validate-email-on-signup-with-workos
TBonnin
approved these changes
May 21, 2024
…-validate-email-on-signup-with-workos
bodinsamuel
reviewed
May 21, 2024
| const user = getUser.value; | ||
|
|
||
| if (!user.email_verified) { | ||
| sendVerificationEmail(user.email, user.name, user.email_verification_token as string); |
There was a problem hiding this comment.
I feel like it's a huge side effect imo
There was a problem hiding this comment.
Yeah, wasn't sure what to do here, but refactored it so that a button appears to re-trigger the verification email.
verification-email.mov
Comment on lines
+56
to
+57
| const salt = crypto.randomBytes(16).toString('base64'); | ||
| const hashedPassword = (await util.promisify(crypto.pbkdf2)(password, salt, 310000, 32, 'sha256')).toString('base64'); |
There was a problem hiding this comment.
could be worth factorizing this since it's used multiples times
| } | ||
| }; | ||
|
|
||
| if (!loaded) { |
There was a problem hiding this comment.
this is seems more related to the button that the page, it flickers when clicking
There was a problem hiding this comment.
Couldn't reproduce. Can you show an example of this?
There was a problem hiding this comment.
Screen.Recording.2024-05-22.at.09.49.45.mov
…-validate-email-on-signup-with-workos
bodinsamuel
approved these changes
May 22, 2024
khaliqgant
deleted the
khaliq/nan-869-validate-email-on-signup-with-workos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Verify a user's email on signup and route them through an email verification flow.
Issue ticket number and link
NAN-869
Checklist before requesting a review (skip if just adding/editing APIs & templates)