x86: Sign-extend 32-bit immediates for 64-bit SBB instructions #6521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 64-bit immediate form of the SBB (Integer Subtraction With Borrow) instruction, uses the wrong field variant for the immediate, causing it to be zero-extended instead of sign-extended.
e.g.:
4f1dffffffff
"SBB RAX,-0x1"x86:LE:64:default
(Existing): "SBB RAX,0xffffffff" { RAX=0xffffffff00000001, CF=1, SF=1 }x86:LE:64:default
(This patch): "SBB RAX,-0x1" { RAX=0x1, CF=1, SF=0 }