AArch32: ldaexd addr src register aliased as first dest register causing second word load at the value of first load #6526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a research project testing the accuracy of the SLEIGH specifications compared to real hardware, we observed an unexpected behaviour in the
ldaexd
instruction for both, AArch32 (ARM:LE:32:v8
) & Thumb (ARM:LE:32:v8T
).According to the manual, the expected behaviour is to load a double-word from address specified in the source register and write it to the two destination registers. However, when the source register and the first destination register are aliased, it causes the second word to load at an incorrect address, i.e, the value retrieved from the first load.
e.g, for AArch32 with,
Instruction:
0x9f0eb061, ldaexdvs r0,r1,[r0]
initial_memory:
{ "0xF0000000": [ 0x0, 0x0, 0x0, 0x0 ] }
initial_registers:
{ "r0": 0xf0000000, "OV": 0x1 }
We get:
Hardware:
{ "r0": 0x0, "r1": 0x86369acc }
Patched Spec:
{ "r0": 0x0, "r1": 0x86369acc }
Existing Spec:
{ "r0": 0x0, "r1": 0xcf267ce8 }
e.g, for Thumb with,
Instruction:
0xd2e8f02b, ldaexd r2,r11,[r2]
initial_memory:
{ "0xF0000000": [ 0xff, 0xf, 0x0, 0x0 ] }
initial_registers:
{ "r2": 0xf0000000 }
We get:
Hardware:
{ "r11": 0x86369acc, "r2": 0xfff }
Patched Spec:
{ "r11": 0x86369acc, "r2": 0xfff }
Existing Spec:
{ "r11": 0x50d3b340, "r2": 0xfff }
Note: The patched spec does not introduce any disassembly changes to the best of our knowledge.