Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.lazy-import: remove #313056

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented May 20, 2024

Description of changes

Remove python3Packages.lazy-import

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Moraxyc Moraxyc added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 20, 2024
@Moraxyc Moraxyc requested a review from Aleksanaa May 20, 2024 05:11
@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 20, 2024

Result of nixpkgs-review pr 313056 run on x86_64-linux 1

4 packages built:
  • python311Packages.lazy-import
  • python311Packages.lazy-import.dist
  • python312Packages.lazy-import
  • python312Packages.lazy-import.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This library has not been maintained for 7 years and there are no packages that depend on it.
So we should consider dropping it.
https://github.com/mnmelo/lazy_import

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 20, 2024

just remove it or mark as broken?

@Aleksanaa
Copy link
Member

Just remove it. Add a removal notice in pkgs/top-level/python-aliases.nix

@Moraxyc Moraxyc changed the title python312Packages.lazy-import: fix distutils usage python312Packages.lazy-import: remove May 20, 2024
@natsukium natsukium merged commit e81dc99 into NixOS:master May 20, 2024
26 of 27 checks passed
@Moraxyc Moraxyc deleted the fix-lazy-import branch May 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants