This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Handle invalid mods better #1861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeffryes
commented
Jan 15, 2020
| return anySupportedByWallet(this.modCurs); | ||
| const isFeeFiat = this.fixedFeeCur && isFiatCur(this.fixedFeeCur); | ||
| const isFeeCrypto = this.fixedFeeCur && anySupportedByWallet([this.fixedFeeCur]); | ||
| const validFeeCur = isFeeFiat || isFeeCrypto; |
There was a problem hiding this comment.
I didn't see an existing method for checking if a currency code was a known fiat or crypto, if there is one that could be swapped in here.
|
This is closed in favor of #1864, since non-critical updates should be happening on eth-master instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior in settings/store so invalid moderators (moderators with models that don't validate) are still shown.
The card will validate the model and show an error if it is invalid, with the specific errors listed in the card.
Sometimes isValid returned true when I manually put in invalid data for the models, which is weird. I wasn't able to figure out the cause, so there's an extra layer of checking in the card template that protects the fee data, and shows the existing currency mismatch message instead of the currency information if the currency code for the fixedFee is unknown or invalid.