Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inline code style #1909

Merged
merged 4 commits into from
May 20, 2024
Merged

feat: add inline code style #1909

merged 4 commits into from
May 20, 2024

Conversation

Shimada666
Copy link
Contributor

#1907

use github style

image

Copy link
Collaborator

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I do feel the inline code is more distinguishable than before, but maybe it could be even better, by making the message background color a bit darker?

@Shimada666
Copy link
Contributor Author

The messages from the assistant currently use the background color bg-neutral-500, while messages from the user use bg-neutral-700. If we make the assistant's message background color darker, like bg-neutral-600, the contrast with the user's messages will be less pronounced. Do you have some good idea?

image image

@iFurySt
Copy link
Collaborator

iFurySt commented May 20, 2024

image
image

@openartist has designed the chat bubble style before, you can use it as a reference. will it look better if add a radius to the code block? wdyt

Copy link
Collaborator

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! As @iFurySt suggested, the regular code block would also look better if it had some radius on it as well. This PR is a good opportunity to make that change as well.

I think it is either a change to the frontend/src/components/markdown/code.tsx component or its parent.

@Shimada666
Copy link
Contributor Author

Shimada666 commented May 20, 2024

@amanape @iFurySt

Good suggestion.😁 I added some radius to the code block. It looks like this.
image

Is there anything else we should add?

@amanape
Copy link
Collaborator

amanape commented May 20, 2024

@Shimada666 Nice! This looks good

@amanape amanape enabled auto-merge (squash) May 20, 2024 06:56
@amanape amanape merged commit 3e3dcd5 into OpenDevin:main May 20, 2024
25 checks passed
li-boxuan pushed a commit to li-boxuan/OpenDevin that referenced this pull request May 21, 2024
* feat: add inline code style

* feat: add code block radius

---------

Co-authored-by: sp.wack <83104063+amanape@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants