This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Multi language labels #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravestench
reviewed
Nov 26, 2020
gravestench
reviewed
Nov 26, 2020
gravestench
reviewed
Nov 26, 2020
added 2 commits
November 26, 2020 11:13
gravestench
reviewed
Nov 26, 2020
added 2 commits
November 26, 2020 11:48
gravestench
reviewed
Nov 26, 2020
Comment on lines
-138
to
-142
| // SplitIntoLinesWithMaxWidthOneLine does the same as SplitIntoLinesWithMaxWidth but return string with newline char | ||
| func SplitIntoLinesWithMaxWidthOneLine(s string, l int) string { | ||
| return strings.Join(SplitIntoLinesWithMaxWidth(s, l), "\n") | ||
| } | ||
|
|
There was a problem hiding this comment.
Thank you fr removing this :)
gravestench
reviewed
Nov 26, 2020
d2game/d2gamescreen/main_menu.go
Outdated
| paladinDescr | ||
|
|
||
| //nolint:deadcode,varcheck,unused // will be used, or is need | ||
| notUsed1 // this position isn't used here. |
There was a problem hiding this comment.
i think you can put _ if you want to skip an index here
gravestench
reviewed
Nov 26, 2020
gravestench
approved these changes
Nov 26, 2020
added 2 commits
November 26, 2020 13:51
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Labels in Main Menu should now depends on string tables.
I don't say, that's a perfect solution of #944, but it works for now.
Let me know, is main_menu.go right place to put this "table interpretation", or maybe better to put it into d2resource?