Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the Carp::Assert package #3785

Merged
merged 1 commit into from
Jun 1, 2024
Merged

updated the Carp::Assert package #3785

merged 1 commit into from
Jun 1, 2024

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Aug 30, 2023 •
edited

this pull fixes the warning:

test ubuntu-22.04 (perl latest) x64: src/deps/Carp/Assert.pm#L385
Old package separator "'" deprecated

I updated the package to version 0.22

but i didn't test openkore work!

@ya4ept ya4ept marked this pull request as ready for review September 9, 2023 22:12
ErikDahlinghaus
ErikDahlinghaus approved these changes Oct 12, 2023
View reviewed changes
Copy link

@ErikDahlinghaus ErikDahlinghaus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this on my rogue and priest for 10 minutes and I had no errors.

EDIT: been running 6 hours now, no issues

sctnightcore
sctnightcore approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@sctnightcore sctnightcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ya4ept ya4ept merged commit 2fca822 into master Jun 1, 2024
9 checks passed
@ya4ept ya4ept deleted the fix_Carp-Assert branch June 1, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikDahlinghaus ErikDahlinghaus ErikDahlinghaus approved these changes

@sctnightcore sctnightcore sctnightcore approved these changes

Assignees
No one assigned
Labels
code cleaning needs to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ya4ept @ErikDahlinghaus @sctnightcore