[helm] add config options for proxy/registry, and add an optional k8s ingress alternative to traefik #8780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s alternative to traefik
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
packages/grid/helm/syft/templates/registry/registry-statefulset.yaml
Outdated
Show resolved
Hide resolved
rasswanth-s
reviewed
May 28, 2024
packages/grid/helm/syft/templates/registry/registry-service.yaml
Outdated
Show resolved
Hide resolved
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
rasswanth-s
reviewed
May 28, 2024
|
I am currently merging the changes requested as they were minimal and to get the changes deployed in new version for testing. |
rasswanth-s
previously approved these changes
May 28, 2024
rasswanth-s
dismissed
their stale review
Keeping my review pending, as I found some blockers during testing on a live cluster
rasswanth-s
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adjusts the existing helm chart to allow flexibility in deploy around the optional components that might not be required in a production environment: registry (in case you are using another image registry already in your k8s cluster) and proxy (this allows for a regular k8s ingress to be used instead with whatever IngressClass you already have configured in the cluster).
Affected Dependencies
Helm chart
How has this been tested?
Tested this in an enterprise testing environment that comprises an nginx ingress (with two ingress classes, a public and a private) and with a registry. Validated that the proxy component still worked by exercising the following paths:
/blob- for seaweedfs including the path stripping/- for frontend/redoc- for backendChecklist